Skip to content

Conversation

wdsmith-lab
Copy link

@wdsmith-lab wdsmith-lab commented Aug 8, 2025

I am submitting a new Community Plugin

ControlledVocabs_Community_Proposal.md

Repo URL

Link to my plugin: https://github.com/wdsmith-lab/obsidian-controlled-vocabs

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Aug 9, 2025
@wdsmith-lab
Copy link
Author

RE: [1]Casting to any should be avoided as much as possible -

The code is using (this as any)["inputEl"] to access a protected member of the AbstractInputSuggest class. While this is not ideal, it's a common workaround when a class doesn't expose the necessary properties. Since this is an optional recommendation, and because it would involve a deeper refactoring of the FileSuggest class, I have added to this to the development task list to search a more "correct" solution. Please advise if this is not acceptable.

@wdsmith-lab
Copy link
Author

wdsmith-lab commented Aug 10, 2025

Closing this PR as I've decided to rebrand the plugin to 'Lexicon' for better user
accessibility and discoverability. I will resubmit under the new name. Thank you for your time and consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants