Skip to content

Add plugin: Note to RED #5689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Conversation

Yeban8090
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin:https://github.com/Yeban8090/note-to-red

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add new plugin: note-to plugin Add plugin: Note to RED Mar 13, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1][2][3][4][5][6][7][8][9][10][11][12]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements

[1]:Do not detach leaves with your custom view in onunload, this is an antipattern, see: https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Don't+detach+leaves+in+%60onunload%60


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Mar 14, 2025
@Yeban8090
Copy link
Contributor Author

I have pushed all the necessary changes to the repo

@Yeban8090
Copy link
Contributor Author

I have pushed all the necessary changes to the repo again.

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Mar 15, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 15, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Mar 23, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Mar 23, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@joethei
Copy link
Collaborator

joethei commented Mar 31, 2025

private updateTimer: NodeJS.Timeout | null = null;
Use a regular number as the type here, and use window.setTimeout / window.clearTimeout where this is being used.

@joethei joethei self-assigned this Mar 31, 2025
@joethei joethei added Changes made Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Mar 31, 2025
@Yeban8090
Copy link
Contributor Author

private updateTimer: NodeJS.Timeout | null = null; Use a regular number as the type here, and use window.setTimeout / window.clearTimeout where this is being used.

Thank you very much for your review. I have fixed this issue and submitted it to the main branch. I have also repackaged the releases. Could you please review it again?

private updateTimer: number | null = null;
async onFileModify(file: TFile) {
if (file === this.currentFile && !this.isPreviewLocked) {
if (this.updateTimer) {
window.clearTimeout(this.updateTimer);
}

        this.updateTimer = window.setTimeout(() => {
            this.updatePreview();
        }, 500);
    }
}

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@joethei joethei added Changes made and removed Minor changes requested PR can be merged after some final changes have been requested Ready for review labels Apr 1, 2025
@joethei joethei merged commit 4bf3da1 into obsidianmd:master Apr 3, 2025
1 check passed
@Yeban8090 Yeban8090 deleted the add-note-plugin branch April 14, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants