Skip to content

Add plugin: Large Language Models #5520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

eharris128
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/eharris128/Obsidian-LLM-Plugin

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    • I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add plugin: large language models Add plugin: Large Language Models Feb 27, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Feb 28, 2025
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@Zachatoo
Copy link
Collaborator

What sets your plugin apart from the other existing Chat-GPT/GPT-3 plugins?

.setName("logprobs"), .setName("top_logprobs"), text: "LLM Plugin",, header.setHeader(modelName, "LLM Plugin");, Header.setHeader(this.modelName, "Local LLM Plugin");
Use sentence case in UI

text.inputEl.addEventListener('blur', () => {, text.inputEl.addEventListener('blur', () => {, text.inputEl.addEventListener('blur', () => {
Please don't do this, you have a Setting already for setting the default model.

export const TAB_VIEW_TYPE = "tab-view";
Don't have two separate view types and commands for the same view. A user can move views around the workspace, this will create confusion for the user if they create your view in the sidebar, move it to the main pane, then try to open your view in the sidebar again.


In your settings tab, consider having the dropdown to select the model first, then conditionally show only a single input for the API key based on the selected model in the dropdown, so you aren't showing irrelevant settings.

@Zachatoo Zachatoo self-assigned this Mar 14, 2025
@Zachatoo Zachatoo added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Mar 14, 2025
@eharris128
Copy link
Contributor Author

Thank you for the review.

We will address the issues and respond to your question.

Cheers.

@eharris128
Copy link
Contributor Author

Great call out with the settings page cleanup.

Thank you as well for the sentence casing catches.

I believe I have addressed everything in my most recent release.

If I missed anything, or if there are other items you would like me to address. Please let me know.

Regarding the true question, why another LLM plugin?

My collaborators and I think the offering of:

  • GPT4All support
  • Integration with OpenAI Assistants
  • A floating action button as an interaction modality

Come together to create a unique plugin, outside of just being another plug in your keys ChatGPT wrapper.

@eharris128
Copy link
Contributor Author

Curious if there is anything else I need to address?

@Zachatoo Zachatoo added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Minor changes requested PR can be merged after some final changes have been requested labels Mar 29, 2025
@Zachatoo Zachatoo assigned joethei and unassigned Zachatoo Mar 29, 2025
@Zachatoo
Copy link
Collaborator

Not sure why the bot didn't move this forward, moving forward now.

@eharris128
Copy link
Contributor Author

Not sure why the bot didn't move this forward, moving forward now.

Many thanks :)

@joethei
Copy link
Collaborator

joethei commented Apr 4, 2025

Copyright (c) 2024 Ryan Mahoney
Update this to include everybody that contributed so far.

// Mac
You are forgetting about Linux here, and this will also break on mobile.

export function hideContainer(container: HTMLElement) {
Use the existing show() / hide() functions that are available on HTMLElement

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Apr 4, 2025
@eharris128
Copy link
Contributor Author

Thank you for the feedback.

I will address it shortly.

Why do you think that the line will break on mobile?

I wrote a wrapper to address this issue so it does not break on mobile.

https://github.com/eharris128/Obsidian-LLM-Plugin/blob/main/src/services/OperatingSystem.ts#L10

Because without the wrapper, the code does indeed break on mobile.

@eharris128
Copy link
Contributor Author

Examples of the 0.19.18 (latest release as of 08 April 2025) installed via BRAT and running successfully on mobile:

AB23A27E-F9B7-4E5B-B17B-2CB3F2085D18(1)

Please let me know if it looks like anything else is off.

Thank you :)

@eharris128
Copy link
Contributor Author

Hi @Zachatoo -> maybe it is something about how my repository is setup, but this pull request again does not seem to shifting out of changes requested after I have pushed up my most recent tag.

Please let me know if there is something else I have to do.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Apr 15, 2025
@joethei joethei merged commit 9e6d8d0 into obsidianmd:master Apr 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants