-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add plugin: Large Language Models #5520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The automated review has not found any issues with your code, ready for manual review. |
What sets your plugin apart from the other existing Chat-GPT/GPT-3 plugins? .setName("logprobs"), .setName("top_logprobs"), text: "LLM Plugin",, header.setHeader(modelName, "LLM Plugin");, Header.setHeader(this.modelName, "Local LLM Plugin"); text.inputEl.addEventListener('blur', () => {, text.inputEl.addEventListener('blur', () => {, text.inputEl.addEventListener('blur', () => { export const TAB_VIEW_TYPE = "tab-view"; In your settings tab, consider having the dropdown to select the model first, then conditionally show only a single input for the API key based on the selected model in the dropdown, so you aren't showing irrelevant settings. |
Thank you for the review. We will address the issues and respond to your question. Cheers. |
Great call out with the settings page cleanup. Thank you as well for the sentence casing catches. I believe I have addressed everything in my most recent release. If I missed anything, or if there are other items you would like me to address. Please let me know. Regarding the true question, why another LLM plugin? My collaborators and I think the offering of:
Come together to create a unique plugin, outside of just being another plug in your keys ChatGPT wrapper. |
Curious if there is anything else I need to address? |
Not sure why the bot didn't move this forward, moving forward now. |
Many thanks :) |
Copyright (c) 2024 Ryan Mahoney // Mac export function hideContainer(container: HTMLElement) { |
Thank you for the feedback. I will address it shortly. Why do you think that the line will break on mobile? I wrote a wrapper to address this issue so it does not break on mobile. https://github.com/eharris128/Obsidian-LLM-Plugin/blob/main/src/services/OperatingSystem.ts#L10 Because without the wrapper, the code does indeed break on mobile. |
Hi @Zachatoo -> maybe it is something about how my repository is setup, but this pull request again does not seem to shifting out of Please let me know if there is something else I have to do. |
Signed-off-by: Evan Harris <[email protected]>
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/eharris128/Obsidian-LLM-Plugin
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.README.md
.