Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Fold Properties By Default #5181

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tbergeron
Copy link

@tbergeron tbergeron commented Jan 19, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/tbergeron/obsidian-fold-properties-by-default

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word obsidian in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin ID mismatch, the ID in this PR (fold-properties-by-default) is not the same as the one in your repo (obsidian-fold-properties-by-default). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 20, 2025
@tbergeron
Copy link
Author

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Optional

[1]:Casting to any should be avoided as much as possible.

Do NOT open a new PR for re-validation.

I know this is an automated bot but just FYI, this has been fixed.

@Zachatoo
Copy link
Collaborator

console.warn('folding properties')
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.


I know you don't have it in your releases, but consider removing the styles.css file from your repo as well if you aren't using it.

@Zachatoo Zachatoo self-assigned this Jan 31, 2025
@Zachatoo Zachatoo added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jan 31, 2025
Copy link

github-actions bot commented Feb 3, 2025

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: GizmoRay/obsidian-goal-tracker. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@tbergeron
Copy link
Author

console.warn('folding properties') Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

I know you don't have it in your releases, but consider removing the styles.css file from your repo as well if you aren't using it.

@Zachatoo I have followed your suggestions. It's been pushed to my repository.

I tried resolving the merge conflict but didn't know I needed to move my plugin to the bottom of the file so now the merging is blocked. I'm not sure what to do here, I believe only you can resolve this?

Thank you for the feedback and let me know if there's anything else.

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Feb 5, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Feb 5, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@ObsidianReviewBot
Copy link
Collaborator

Changes requested by Zachatoo have been made, assigning additional human for additional review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants