Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Hephaistos Importer #4995

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Skallaturi
Copy link

@Skallaturi Skallaturi commented Dec 28, 2024

Added Hephaistos Importer

I am submitting a new Community Plugin

Repo URL

Link to my plugin:

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Hephaistos Importer plugin Add plugin: Hephaistos Importer Dec 28, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Dec 29, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@joethei
Copy link
Collaborator

joethei commented Jan 13, 2025

// If the plugin hooks up any global DOM events (on parts of the app that doesn't belong to this plugin)
Remove this sample code.

@joethei joethei self-assigned this Jan 13, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 13, 2025
@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 23, 2025
Added Hephaistos Importer
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 2.0.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@Skallaturi
Copy link
Author

Shortly after I created this pull request, the author of the Hephaistos website announched a change to the API that deeply affected the plugin.
I have rewritten the plugin from scratch, but am awaiting a crucial bugfix on the API before I can continue.

@Skallaturi
Copy link
Author

Shortly after I created this pull request, the author of the Hephaistos website announched a change to the API that deeply affected the plugin. I have rewritten the plugin from scratch, but am awaiting a crucial bugfix on the API before I can continue.

I have tested against the new version of the API and am ready to merge

Copy link

github-actions bot commented Feb 3, 2025

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: GizmoRay/obsidian-goal-tracker. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@Skallaturi
Copy link
Author

NOW it's ready for review. Sorry about the delay.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3]:Using innerHTML, outerHTML or similar API's is a security risk. Instead, use the DOM API or the Obsidian helper functions: https://docs.obsidian.md/Plugins/User+interface/HTML+elements


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Feb 4, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Feb 4, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants