Notion API: fix the toggle convert & file name error #459
Conversation
|
I made some changes to the |
Xheldon
changed the title
Xheldon
changed the title
Xheldon
changed the title
| // If the result is empty or only whitespace after sanitization, return a default name | ||
| // This prevents creating files like ".md" (no name) or folders with only spaces | ||
| const trimmed = sanitized.trim(); | ||
| return trimmed || 'Untitled'; |
There was a problem hiding this comment.
I think generally this is a good change, however, in importDatabaseCore of the Notion API importer it would previously use Untitled Database if this function returned an empty value and now it will just return Untitled.
There was a problem hiding this comment.
Indeed, but compared to checking the return value at every sanitizeFileName function call, I don’t think it’s that important. Do you think this part must, as before, return a possible empty string value for backward compatibility?
src/util.ts
Outdated
| const sanitized = name | ||
| .replace(illegalRe, '') | ||
| .replace(controlRe, '') | ||
| .replace(controlRe, '') |
There was a problem hiding this comment.
I run npm run lint before each commit, but occasional spacing and comment indentation issues do occur, possibly due to my editor configuration; I’ll take a closer look.
|
|
||
| let headingText = ''; | ||
| let headingPrefix = ''; | ||
| let headingData: Heading1BlockObjectResponse['heading_1'] | Heading2BlockObjectResponse['heading_2'] | Heading3BlockObjectResponse['heading_3']; |
There was a problem hiding this comment.
| let headingData: Heading1BlockObjectResponse['heading_1'] | Heading2BlockObjectResponse['heading_2'] | Heading3BlockObjectResponse['heading_3']; | |
| let headingData: HeaderContentWithRichTextAndColorResponse; |
| let headingText = ''; | ||
| let headingPrefix = ''; | ||
| let headingData: Heading1BlockObjectResponse['heading_1'] | Heading2BlockObjectResponse['heading_2'] | Heading3BlockObjectResponse['heading_3']; | ||
| let isToggleable = false; |
There was a problem hiding this comment.
isToggleable can be defined after the if-block below without any casting required.
const isToggleable = headingData.is_toggleable || false;There was a problem hiding this comment.
Yes, that part was overly verbose, so I refactored it, along with the headingData above, see: 8496eff
2 participants
In Notion, if a Toggle's title is a Heading, then it is a Heading block, not Toggle🥲