Skip to content

Improve the user-friendliness of the CiGri command line interface #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jgaida opened this issue Jul 10, 2015 · 5 comments
Open

Improve the user-friendliness of the CiGri command line interface #20

jgaida opened this issue Jul 10, 2015 · 5 comments
Assignees
@bzizou
Labels
enhancement User interaction
Milestone
ASAP

Comments

@jgaida
Copy link

jgaida commented Jul 10, 2015

Improve gridevents --help:

  • -c -e -g always mandatory. Puts them first
  • -r can only be used with -f
  • hide admin options
@jgaida
Copy link
Author

jgaida commented Jul 10, 2015

  • griddel does not display an error message when applied to an already deleted campaign.
  • some cmd requires "-c" in front of the campaign_id. Some don't (griddel). Some accepts both syntax (gridstat).

@jgaida
Copy link
Author

jgaida commented Jul 10, 2015

@jgaida
Copy link
Author

jgaida commented Jul 10, 2015

--help for gridevents -r already modified :

opts.on('-r', '--resubmit', 'Resubmit each job concerned by the fixed events (needs --fix') do

@bzizou bzizou added this to the ASAP milestone Jul 15, 2015
@bzizou
Copy link
Contributor

bzizou commented Jul 16, 2015

Moreover, there's a mess with the '-c' option into gridstat. It is overlwritten by "--cinfos". This is a bug...

@bzizou bzizou self-assigned this Jul 16, 2015
bzizou added a commit that referenced this issue Jul 16, 2015
@bzizou
Cmd line improvements (issue #20)
e0e6333 
gridevents --help:

    -c -e -g always mandatory. Puts them first
    -r can only be used with -f
    hide admin options

griddel now accepts "-c id1,id2,..." syntax
bzizou added a commit that referenced this issue Jul 16, 2015
@bzizou
griddel now displays error messages when necessary (#20)
36a26d1 
Griddel now checks the state of campaign before actual action on hold, resume, purge and cancel and displays an error message for an operation that can't be done (for example cancel an already cancelled capaign)
@bzizou
Copy link
Contributor

bzizou commented Jul 16, 2015

Almost everything done and committed.
Still working on improving gridevents:

  • should be more explicit for "not found" campaign than the default "Failed to fix event(s): DELETE https://127.0.0.1:4444/campaigns/18/events not found on this server"
  • should print something when events are actually fixed, e.g.: "Fixed 1 event(s)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzizou bzizou

Labels
enhancement User interaction
Projects
None yet
Milestone
ASAP
Development

No branches or pull requests
2 participants
@bzizou @jgaida