Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why block syntax needed for options? #17

Open
ziy opened this issue Apr 3, 2013 · 4 comments
Open

Why block syntax needed for options? #17

ziy opened this issue Apr 3, 2013 · 4 comments
Labels

Comments

@ziy
Copy link
Member

ziy commented Apr 3, 2013

Why do we need to put a vertical bar to make the options as a block? For example,

pipeline:
  - inherit: ecd.phase
    name: keyterm-expansion
    options: |
      - inherit: helloqa.keyterm.simple

It might be more intuitive to have the value type for the key "options" as a list (aka an Iterable), so that parameter value can be flattened to higher layers, and we will be one step closer to present the "effective yaml description".

pipeline:
  - inherit: ecd.phase
    name: keyterm-expansion
    options:
      - inherit: helloqa.keyterm.simple
        param: value
@elmer-garduno
Copy link
Contributor

Yes I agree with the intuition, but I guess it's done in that way to make
it consistent with the inherited parameters? As they are parsed as strings.

Does that makes sense?

On Tue, Apr 2, 2013 at 10:09 PM, Zi Yang [email protected] wrote:

Why do we need to put a vertical bar to make the options as a block? For
example,

pipeline:

  • inherit: ecd.phase
    name: keyterm-expansion
    options: |
    • inherit: helloqa.keyterm.simple

It might be more intuitive to have the value type for the key "options" as
a list (aka an Iterable), so that parameter value can be flattened to
higher layers, and we will be one step closer to present the "effective
yaml description".

pipeline:

  • inherit: ecd.phase
    name: keyterm-expansion
    options:
    • inherit: helloqa.keyterm.simple
      param: value


Reply to this email directly or view it on GitHubhttps://github.com//issues/17
.

@elmer-garduno
Copy link
Contributor

I also remember having problems parsing nested things inside the inherits
that's why the ! syntax was there. But maybe that's old stuff and we can
move on.

On Tue, Apr 2, 2013 at 10:27 PM, Elmer Garduno [email protected] wrote:

Yes I agree with the intuition, but I guess it's done in that way to make
it consistent with the inherited parameters? As they are parsed as strings.

Does that makes sense?

On Tue, Apr 2, 2013 at 10:09 PM, Zi Yang [email protected] wrote:

Why do we need to put a vertical bar to make the options as a block? For
example,

pipeline:

  • inherit: ecd.phase
    name: keyterm-expansion
    options: |
    • inherit: helloqa.keyterm.simple

It might be more intuitive to have the value type for the key "options"
as a list (aka an Iterable), so that parameter value can be flattened to
higher layers, and we will be one step closer to present the "effective
yaml description".

pipeline:

  • inherit: ecd.phase
    name: keyterm-expansion
    options:
    • inherit: helloqa.keyterm.simple
      param: value


Reply to this email directly or view it on GitHubhttps://github.com//issues/17
.

@ziy
Copy link
Member Author

ziy commented Apr 3, 2013

But for things outside the "options", we can achieve this without the block syntax and we can also put paramters. For example,

collection-reader:
  inherit: helloqa.collection.collection-reader

@elmer-garduno
Copy link
Contributor

You are right it might be time to try again without blocks

On Tue, Apr 2, 2013 at 10:35 PM, Zi Yang [email protected] wrote:

But for things outside the "options", we can achieve this without the
block syntax and we can also put paramters. For example,

collection-reader:
inherit: helloqa.collection.collection-reader


Reply to this email directly or view it on GitHubhttps://github.com//issues/17#issuecomment-15814540
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants