Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send fails when // is given as path #356

Open
schuelermine opened this issue Jul 5, 2021 · 1 comment · May be fixed by #357
Open

send fails when // is given as path #356

schuelermine opened this issue Jul 5, 2021 · 1 comment · May be fixed by #357

Comments

@schuelermine
Copy link

Send fails when // is given as a path because resolvePath throws an error if the second argument is an absolute path, and the call to std’s path.parse to find out the length of the root (since it is different on Windows) to strip it out doesn’t catch this.
@schuelermine
Copy link
Author

I’m not sure if this is an upstream issue in Deno’s standard library, or if this should be fixed here. If so, I’m willing to attempt a fix.

schuelermine added a commit to schuelermine/oak that referenced this issue Jul 5, 2021
@schuelermine
Strip trailing slashes from path in send
ef6f7c0 
Adds import of sep from std/path
Attempt to fix oakserver#356
@schuelermine schuelermine linked a pull request Jul 5, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempt to fix #356 schuelermine/oak
1 participant
@schuelermine