Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line secrets are not redacted when "Running Command:" #37

Open
tonglil opened this issue Mar 28, 2018 · 2 comments
Open

Multi-line secrets are not redacted when "Running Command:" #37

tonglil opened this issue Mar 28, 2018 · 2 comments
Labels

Comments

@tonglil
Copy link
Member

tonglil commented Mar 28, 2018

Drone GAE Plugin built from 1e5e603cf8fe827a2ee0f1aced22361f00d6a714
Running Command: /google-cloud-sdk/bin/gcloud auth activate-service-account --key-file /tmp/gcloud.json
Activated service account credentials for: [[email protected]]
Running Command: /go_appengine/appcfg.py  --oauth2_access_token  [redacted] 
-A yyy -V zzz -E API_KEY: [redacted] -E CREDENTIALS: [redacted] "type": "service_account", "project_id": "xyz", "private...
@tonglil tonglil added the bug label Mar 28, 2018
@almadireddy
Copy link
Contributor

Is there a project somewhere I can look at for reference that has this issue?

@jprobinson
Copy link
Contributor

The easiest way to reproduce this problem within Drone itself would be to add a multi-line string in the 'ae_environment' drone plugin config and then use action: update with a Go 1.9 GAE application.

Go 1.11+ apps use action: deploy, which will not attempt to pass variables via the -E and potentially expose them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants