Error when processing Medivh patch

[crorella]

Hello,

I'm getting the following error while trying to generate the json file from the newest patch (43571)

Error: Failed to get XML ref [Behavior,FalstadHammerGains,Modification.VitalDamageLeechArray[0].KindArray[2]], result is NaN for hero: Falstad at lookupXMLRef (/Users/cristiano/Others/heroesjson/generate.js:1009:10) at /Users/cristiano/Others/heroesjson/generate.js:795:38 at Array.forEach (native) at /Users/cristiano/Others/heroesjson/generate.js:786:158 at Array.forEach (native) at getFullDescription (/Users/cristiano/Others/heroesjson/generate.js:766:59) at /Users/cristiano/Others/heroesjson/generate.js:351:24 at Array.forEach (native) at processHeroNode (/Users/cristiano/Others/heroesjson/generate.js:322:18) at /Users/cristiano/Others/heroesjson/generate.js:169:81

@jnovack , any idea on how to fix it?

[jnovack]

will probably need a rewrite for [Behavior,FalstadHammerGains,Modification.VitalDamageLeechArray[0].KindArray[2]]
to
[Behavior,FalstadHammerGains,Modification.VitalDamageLeechArray[0].KindArray[0]]

Look in shared/C.js.

I'll try to get the patch out tonight.

[crorella]

Thanks for the reply. I will try to understand the logic behind that change.

[jnovack]

I don't understand it either. There is only 1 element (element 0) in the VitalDamageLeechArray, however, the game properly prints the right message. Either the game does some combining which I do not understand or there are some additional "cleanup" magic.

Within mods/heroesdata.stormmod/base.stormdata/GameData/BehaviorData.xml you can see there is only 1 (element 0) value down the tree of Modification.VitalDamageLeechArray.KindArray. Thus to me, it's element 0. But Blizzard thinks it's element 2. I'd really like to know why. :(

    <CBehaviorBuff id="FalstadHammerGains">
        <Face value="GenericVigorousAssaultTalent"/>
        <Cost>
            <Charge Link="Behavior/TalentBucketVigorousAssault"/>
            <Cooldown Link="Behavior/TalentBucketVigorousAssault"/>
        </Cost>
        <BehaviorFlags index="Permanent" value="1"/>
        <BehaviorFlags index="EnabledWhileDead" value="1"/>
        <Modification>
            <VitalDamageLeechArray index="Life">
                <KindArray index="Ranged" value="0.2"/>
            </VitalDamageLeechArray>
            <VitalDamageLeechScoreArray Validator="TargetIsHero" Value="SelfHealing"/>
        </Modification>
        <DamageResponse>
            <Cost>
                <Charge Link="Behavior/TalentBucketVigorousAssault"/>
                <Cooldown Link="Behavior/TalentBucketVigorousAssault"/>
            </Cost>
        </DamageResponse>
    </CBehaviorBuff>