Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Consistency of Health/Mana Information #40

Closed
LeoLeal opened this issue Jun 11, 2016 · 8 comments
Closed

Consistency of Health/Mana Information #40

LeoLeal opened this issue Jun 11, 2016 · 8 comments

Comments

@LeoLeal
Copy link
Contributor

LeoLeal commented Jun 11, 2016

This is more of a necessity to understand the information contained in the JSON file:

HP per level is displayer as a flat number for a Percentage Value.
Mana per Level is flat value per level.
HP and Mana Regen are flat values per second.
HP is a percentage value per level.

That being said I cant really distinguish when Percentage and flat numbers are being used. These info I could figure out, except Mana Regen per level.

Looking at Anubarak, mana regen per level says 0.0976. Is it a flat number per level or a flat number for percentage value or is it 9.76% per level?

Thanks in advance

@LeoLeal
Copy link
Contributor Author

LeoLeal commented Jun 11, 2016

As a sidenote, skills have their damage in multiplier format while percentade values for stats are flat values for percentage.

It's all your call after all, just letting you know there's a problem of consistency here. :)

Cheers!

@heymATIN
Copy link

@LeoLeal I also opened an Issue, that all those numbers / HP , attack dmg etc. Are pretty old from older versions, it's not up-to-date.

@LeoLeal
Copy link
Contributor Author

LeoLeal commented Jun 14, 2016

I'm feeding a database with them... and thru seem actual. Check the
information ingame.
Em 14 de jun de 2016 2:25 AM, "heymATIN" [email protected]
escreveu:

@LeoLeal https://github.com/LeoLeal I also opened an Issue, that all
those numbers / HP , attack dmg etc. Are pretty old from older versions,
it's not up-to-date.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#40 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABy8rZMNeEvB1rPuHgXvtpPnJYJOLRfKks5qLjszgaJpZM4IzcYl
.

@heymATIN
Copy link

I did, it is not correct. Ingame information is different than what the heroes.json gives us.

@jnovack
Copy link
Member

jnovack commented Jun 15, 2016

The formulas are pulled verbatim. There are a number of formula replacements (shared/C.js) because the formulas do not calculate as-is. There is little to no consistency and a lot of "fall-backs"/defaults for formulas that I would have to find or reverse-engineer to calculate.

That's why it's a cluster fuck. Garbage formulas mean garbage translations.

@LeoLeal
Copy link
Contributor Author

LeoLeal commented Jun 15, 2016

Oh Thats clarified!

I'm treating the values on my side of the App anyways.

Thanks for the info.
Cheers.

@LeoLeal LeoLeal closed this as completed Jun 15, 2016
@heymATIN
Copy link

I just realised something about the stats - HP and stuff. They are correct.
They only start at Level 0.
So the ingame strings start at Level 1.
So it adds up +4% to everything.
I dont understand why. That actually makes no sense. But It is correct. Just EVERYTHING even spells damage and stuff. Starts at Level 0 so those 4% gets add up ingame.

@LeoLeal
Copy link
Contributor Author

LeoLeal commented Jun 22, 2016

Told they were correct
Em 22 de jun de 2016 3:25 AM, "heymATIN" [email protected]
escreveu:

I just realised something about the stats - HP and stuff. They are correct.
They only start at Level 0.
So the ingame strings start at Level 1.
So it adds up +4% to everything.
I dont understand why. That actually makes no sense. But It is correct.
Just EVERYTHING even spells damage and stuff. Starts at Level 0 so those 4%
gets add up ingame.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#40 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABy8rVfXYRJDuxzlXBmBCVKTHLtUhUR-ks5qONVTgaJpZM4IzcYl
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants