Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Potential issue in Cho data #16

Closed
Sembiance opened this issue Feb 9, 2016 · 1 comment
Closed

Potential issue in Cho data #16

Sembiance opened this issue Feb 9, 2016 · 1 comment
Labels

Comments

@Sembiance
Copy link
Contributor

A user reported this to me via e-mail. I have NOT had a chance to investigate it yet to see if it's a valid issue or not:

It seems that there is an issue with Cho's values specifically. It didnt happen in the old files but in this new release I get a parsing error when JSON.parse reached Cho's first ability. After deleting Cho from the json file everything seemed to work just fine.

@jnovack
Copy link
Member

jnovack commented Feb 9, 2016

"this new release" meaning 40431?

Looks good to me...

$ cat heroes.json | jq '.[]|select(.id == "Cho") | .abilities.Cho[0]'
{
  "id": "ChoSurgingFistCast",
  "icon": "storm_ui_icon_Cho_MoltenSurge_A.dds",
  "name": "Surging Fist",
  "description": "Wind up for at least 1 second temporarily slowing yourself, then reactivate to charge in a direction. Enemies in your path are knocked aside and take 46 (+0.04 per level) damage.",
  "cooldown": 13,
  "shortcut": "Q"
}

@jnovack jnovack added the invalid label Mar 4, 2016
@jnovack jnovack closed this as completed Mar 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants