Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Update Steps for Deleted/Renamed Talents #4

Open
ebshimizu opened this issue Jul 27, 2018 · 2 comments
Open

Update Steps for Deleted/Renamed Talents #4

ebshimizu opened this issue Jul 27, 2018 · 2 comments

Comments

@ebshimizu
Copy link
Collaborator

ebshimizu commented Jul 27, 2018

Two files in the heroes-talents module need to be updated for these.

Deleted Talents

  • assets/data/deleted-talents.json - Any talent that is in the previous commit of heroes talents and not the current is placed here. This file loads first, so if a talent comes back for whatever reason, the old version is overwritten by the new one. The stat block is copied directly from the heroes talents file, and is currently done via a manual inspection of the diff.

Renamed Talents

  • game-data/talent-renames.js - If a talent is functionally the same (same description, etc) but the talentTreeId was changed, it gets placed here. Also done manually for now.

These files can be re-located. The directory structure here is specific to how stats of the storm needed things at the time. Files in game-data are mostly used to maintain human-readable strings for various stats and awards.

@jnovack
Copy link
Member

jnovack commented Jul 27, 2018

Has this mostly been a "human" task? Do you diff the files? What is your normal process?

@ebshimizu
Copy link
Collaborator Author

Oh yeah it's all 100% a human task right now. I just go to the commit for the most recent heroes-talents version on github and check to see which talents got changed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants