Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

[Feature request] "type" prop rename #104

Open
nvms opened this issue Feb 23, 2019 · 0 comments
Open

[Feature request] "type" prop rename #104

nvms opened this issue Feb 23, 2019 · 0 comments

Comments

@nvms
Copy link
Owner

nvms commented Feb 23, 2019

any prop that references 'info', 'success', 'warning', 'danger', etc., should be identified by a prop named appearance. currently, the prop is named type on most components.

this would be a breaking change

What problem does this feature solve?

It can get confusing or difficult to remember, since the prop is named differently on various components.

for example:

<va-button appearance="success"> ... </va-button>
<va-lozenge appearance="danger"> ... </va-lozenge>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant