Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor into standalone plugin #503

Closed
clason opened this issue Oct 8, 2023 · 6 comments
Closed

Refactor into standalone plugin #503

clason opened this issue Oct 8, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@clason
Copy link
Collaborator

clason commented Oct 8, 2023

Nvim-treesitter 1.0 (expected later this year) will completely remove the module system in order to significantly reduce complexity.

This means that nvim-treesitter-textobjects needs to be refactored into a standalone plugin, similarly to https://github.com/nvim-treesitter/nvim-treesitter-context or the indent.lua module in 1.0. (There's no need to hook into nvim-treesitter; textobjects should simply work if a suitable parser and queries are in runtimepath. This should also allow simplifying the setup as it no longer needs to be shoehorned into the nvim-treesitter setup structure.)

As a bonus, the incremental-selection (also removed in 1.0) feature could be integrated here as a in/an node object.

@clason clason added the enhancement New feature or request label Oct 8, 2023
@clason clason pinned this issue Oct 8, 2023
@TheLeoP
Copy link

TheLeoP commented Nov 18, 2023

Would a PR be welcome?

@clason
Copy link
Collaborator Author

clason commented Nov 18, 2023

Of course!

@TheLeoP
Copy link

TheLeoP commented Nov 18, 2023

Would the PR also have to remove the dependency on nvim-treesitter?

@clason
Copy link
Collaborator Author

clason commented Nov 18, 2023

Yes, that is the whole point!

@ilan-schemoul

This comment was marked as off-topic.

@clason
Copy link
Collaborator Author

clason commented Aug 3, 2024

I consider this as completed by #523 and the follow-up fixes (thanks all!). Feel free to test it (if and only if you are testing nvim-treesitter main!) and report (or, better yet, fix) any regressions you find.

@clason clason closed this as completed Aug 3, 2024
@nvim-treesitter nvim-treesitter locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants