Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user guide was not correct for the search function #1604

Open
nus-pe-bot opened this issue Nov 16, 2019 · 1 comment
Open

The user guide was not correct for the search function #1604

nus-pe-bot opened this issue Nov 16, 2019 · 1 comment

Comments

@nus-pe-bot
Copy link

in the user guide, only state search for map of a location in SINGAPORE only.

Screenshot 2019-11-15 at 4.59.35 pm.png

But i managed to search for other countries like JOHOR and australia.

Screenshot 2019-11-15 at 4.59.42 pm.png
Screenshot 2019-11-15 at 5.01.16 pm.png


[original: nusCS2113-AY1920S1/pe-interim#1618]
@Jefferson111
Copy link
Contributor

Jefferson111 commented Nov 17, 2019

Team's Response

That is in Singapore, my friend. What you have found is australia international school and johore battery. They are locations that actually exist in Singapore!

From google maps:
Australian International School:
image.png

Johore Battery:
image.png

If anything, we use an external API provided by the government for location searching and for the images for the Map command.

It is not on our side to explain how their API works and why it may return certain results.

The request is sent to the API, based on what you have entered. Whatever location and map is returned is up to the API, and is thus not under us at all.

In this case, these locations actually exist in Singapore and this is what the API will return.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants