Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Violations of LoD #105

Open
aquohn opened this issue Nov 23, 2019 · 3 comments
Open

Violations of LoD #105

aquohn opened this issue Nov 23, 2019 · 3 comments

Comments

@aquohn
Copy link

aquohn commented Nov 23, 2019

image

In the above image, isn't LoD violated by the code? The method call is essentially:

(new MultiFormatReader()).decode(...).getText()

Wouldn't an LoD-compliant implementation be:

(new MultiFormatReader()).decodeToText(...)

?

@Jefferson111
Copy link

Maybe, I think, because MultiFormatReader is something from the library, so not counted as LOD violation by the person who wrote the code snippet

@okkhoy
Copy link
Collaborator

okkhoy commented Nov 23, 2019

qrCodeResult is also created within the method. So no violation

@Jefferson111
Copy link

Jefferson111 commented Nov 23, 2019

@okkhoy
Just to clarify, if something like this would to come out:

String result = new MultiFormatReader().decode().getInfo().getText().toString();

This does not constitutes to violation of LOD because of the new keyword?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants