Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions regarding Ctrl+c and Ctrl+z. #100

Open
ZhangYihanNus opened this issue Nov 18, 2019 · 2 comments
Open

Questions regarding Ctrl+c and Ctrl+z. #100

ZhangYihanNus opened this issue Nov 18, 2019 · 2 comments
Labels

Comments

@ZhangYihanNus
Copy link

During PE, we received issues stating that entering "Ctrl+c" and "Ctrl+z" or EoF, EoL in our program in the terminal will cause our program to crash and terminate with errors.

Are "Ctrl+c" and "Ctrl+z", or EoF, EoL, within the scope of commands to be considered? And what can we do with related issues?

@shamussy
Copy link

It shows nothing was done with regards to checking the contents of the input, such as taking in null when "Ctrl+*" is given. As such, the criteria of error handling / defensive programming when taking in user input is potentially not fulfilled, and if it causes your program to crash, and prohibits the usage of your program, should be counted as a bug in my opinion.

@okkhoy
Copy link
Collaborator

okkhoy commented Nov 18, 2019

These are bugs that appeared due to a lack of validation of inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants