Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SP compute unchecked input #9

Closed
wants to merge 2 commits into from
Closed

Fix SP compute unchecked input #9

wants to merge 2 commits into from

Conversation

breznak
Copy link
Member

@breznak breznak commented Jan 19, 2018 •
edited

  • add test for compute's incorrect sizes of input params
    • unit-test expected to crash crashes the whole build
    • check for correct sizes (need to get size of inputArray[] aka T*)

Fixes numenta#1388
Moved from numenta#1389

TL;DR: valid issue, cannot be resolved when SP/TM use T* as in/out, waiting for move to a container (ei vector) which provide .size()

@breznak
SP: WIP add check for sizes of in/out arrays in compute()
324b17a 
these fields are entered by user and must exactly match the Input, Columns
sizes.
Unfortunately, the array is passed as T* so getting the size will be tricky.
@breznak
SP: add test for invalid array sizes for compute()
84ae3d7
@breznak breznak mentioned this pull request Jan 19, 2018
Closed
3 tasks
@breznak breznak added bug Something isn't working SP labels Jan 19, 2018
@breznak breznak added this to the Community fixes milestone Jan 23, 2018
@breznak breznak removed this from the Community fixes milestone Aug 1, 2018
@breznak breznak added code code enhancement, optimization, cleanup..programmer stuff and removed feature new feature, extending API labels Aug 9, 2018
@breznak
Copy link
Member Author

breznak commented Nov 11, 2018

Closing this PR for now. May revisit if we change the data type for compute() params.

@breznak breznak closed this Nov 11, 2018
@breznak breznak deleted the fix_sp_compute_unchecked_input branch November 11, 2018 20:48
@breznak breznak mentioned this pull request Feb 26, 2019
Open
@ctrl-z-9000-times ctrl-z-9000-times mentioned this pull request May 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working code code enhancement, optimization, cleanup..programmer stuff low on_hold SP waits_dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unchecked input for SP compute crashes program
1 participant
@breznak