You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Argo Rollouts has an option called "Promote full" which means to bypass the standard analysis check and simply promote the new one. Perhaps we could have this option for a Rollout that's either Failed Progressive or has not yet been assessed (i.e. in either case still in "Pending" phase).
We could use a Label on the Rollout called "numaplane.numaproj.io/promote". Either we set it to "true", or it's perhaps a Label with no value, and if the Label exists it means to promote.
If we make it so that that label can be used for all progressive rollouts, then we can just use it in the progressive.go code directly without worrying about which Rollout it is.
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered:
This is the logic we do when we declare success. Perhaps that logic could be moved into a function which we can also call if the Label is set near the top ofprocessUpgradingChild().
Let's have a new Status field, in the UpgradingChildStatus called ForcedSuccess (bool). You can set that to true, and you actually don't need to worry about clearing it, because it will automatically get reset the next time there's an upgrading child.
Summary
Argo Rollouts has an option called "Promote full" which means to bypass the standard analysis check and simply promote the new one. Perhaps we could have this option for a Rollout that's either Failed Progressive or has not yet been assessed (i.e. in either case still in "Pending" phase).
We could use a Label on the Rollout called "numaplane.numaproj.io/promote". Either we set it to "true", or it's perhaps a Label with no value, and if the Label exists it means to promote.
If we make it so that that label can be used for all progressive rollouts, then we can just use it in the progressive.go code directly without worrying about which Rollout it is.
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered: