Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Promote Full" option for Numaplane #573

Open
juliev0 opened this issue Feb 18, 2025 · 2 comments
Open

"Promote Full" option for Numaplane #573

juliev0 opened this issue Feb 18, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Feb 18, 2025

Summary

Argo Rollouts has an option called "Promote full" which means to bypass the standard analysis check and simply promote the new one. Perhaps we could have this option for a Rollout that's either Failed Progressive or has not yet been assessed (i.e. in either case still in "Pending" phase).

We could use a Label on the Rollout called "numaplane.numaproj.io/promote". Either we set it to "true", or it's perhaps a Label with no value, and if the Label exists it means to promote.

If we make it so that that label can be used for all progressive rollouts, then we can just use it in the progressive.go code directly without worrying about which Rollout it is.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the enhancement New feature or request label Feb 18, 2025
@juliev0
Copy link
Collaborator Author

juliev0 commented Feb 20, 2025

This is the logic we do when we declare success. Perhaps that logic could be moved into a function which we can also call if the Label is set near the top of processUpgradingChild().

@juliev0
Copy link
Collaborator Author

juliev0 commented Feb 20, 2025

Let's have a new Status field, in the UpgradingChildStatus called ForcedSuccess (bool). You can set that to true, and you actually don't need to worry about clearing it, because it will automatically get reset the next time there's an upgrading child.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants