Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all the conditions in NumaflowControllerRollout status are true #511

Open
whynowy opened this issue Jan 20, 2025 · 1 comment
Open
Labels
bug Something isn't working

Comments

@whynowy
Copy link
Member

whynowy commented Jan 20, 2025

Describe the bug

Is following expected?

When creating a NumaflowControllerRollout as below, one of the conditions is false.

apiVersion: numaplane.numaproj.io/v1alpha1
kind: NumaflowControllerRollout
metadata:
  name: numaflow-controller
spec:
  controller:
    #instanceID: "0" # uncomment for Progressive rollout to set Numaflow Controller instance
    version: "1.4.2"

Status

status:
  conditions:
  - lastTransitionTime: "2025-01-20T07:28:05Z"
    message: Successful
    observedGeneration: 1
    reason: Successful
    status: "True"
    type: ChildResourceDeployed
  - lastTransitionTime: "2025-01-20T07:28:09Z"
    message: Successful
    observedGeneration: 1
    reason: Successful
    status: "True"
    type: ChildResourcesHealthy
  - lastTransitionTime: "2025-01-20T07:28:05Z"
    message: no need for pause
    observedGeneration: 1
    reason: NoPause
    status: "False"
    type: PausingPipelines

Feel free to close it if it's not a bug.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Kubernetes: [e.g. v1.18.6]

Additional context
Add any other context about the problem here.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

@whynowy whynowy added the bug Something isn't working label Jan 20, 2025
@juliev0
Copy link
Collaborator

juliev0 commented Jan 20, 2025

That's expected, as it's not pausing. But do you think according to Kubernetes expectations, "false" should always be the atypical thing? (In this case, there's no "good" or "bad" per se, but there is "normal" and "atypical".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants