-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch is not part of common nodejs runtime #2
Comments
Is it troublesome to use isomorphic-fetch as a dependent module ? |
It should be part of the dependencies in the |
It's a dilemma. I also thought so in the early stages of development. However, recently fetch has already been implemented in modern browsers. Those browsers do not need the bundled fetch module in the library. So I did not include fetch module in package.json. |
A polyfill needs to be available anyhow (since not all browsers implement it) and you could make a separate "no-fetch.js" that can be deeplinked using |
I see. That is a good idea. In the near future I will try to add that split implementation to this library. Thank you for a good suggestion 😄 |
fetch
as used in src/request.ts#L54 is not part of the common nodejs runtime and returns in an error (making it difficult to use the backlog api)The text was updated successfully, but these errors were encountered: