You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And runner types that are present in GitHubActionsImage, but are missing in the documentation are:
ubuntu-18.04
macos-10.15
macos-11
macos-12
I suggest we either:
a simple solution: sync runner types with documentation - but we'd need to do this regularly
or not-so-simple-but-long-term-solution: change GitHubActionsImage from enum to to a static class with const string for runner types. GitHubActions would need to accept string for runner type instead of an enum. This gives the ease of use for those who want to use whatever is currently supported by Nuke, while giving flexibility for the next time when these runner types get out of sync with what is supported by Github Actions
We'd need to change GitHubActionsAttribute as well:
publicclassGitHubActionsAttribute:ConfigurationAttributeBase{privatereadonlystring_name;privatereadonlystring[]_images;privateGitHubActionsSubmodules?_submodules;privatebool?_lfs;privateuint?_fetchDepth;privatebool?_progress;privatestring_filter;publicGitHubActionsAttribute(stringname,stringimage,paramsstring[]images){_name=name.Replace(oldChar:' ',newChar:'_');_images=new[]{image}.Concat(images).ToArray();}// other code}
We'd also need to fix examples. This would be a breaking change without a doubt but might be better as far as maintenance goes.
Could you help with a pull-request?
Yes
The text was updated successfully, but these errors were encountered:
avidenic
changed the title
Refresh supported runner types for Github actions (currently in preview)
Refresh supported runner types for Github actions (including those currently in preview)
Feb 14, 2025
Description
Github offers different runner types that are currently available in
GitHubActionsImage
According to the documentation, the missing runner types are:
windows-2025
ubuntu-24.04-arm
ubuntu-22.04-arm
macos-13
macos-15
And runner types that are present in
GitHubActionsImage
, but are missing in the documentation are:ubuntu-18.04
macos-10.15
macos-11
macos-12
I suggest we either:
GitHubActionsImage
from enum to to a static class withconst string
for runner types.GitHubActions
would need to accept string for runner type instead of an enum. This gives the ease of use for those who want to use whatever is currently supported by Nuke, while giving flexibility for the next time when these runner types get out of sync with what is supported by Github ActionsNew implementation example
Less breaking implementation
Alternative implementation
We'd need to change
GitHubActionsAttribute
as well:We'd also need to fix examples. This would be a breaking change without a doubt but might be better as far as maintenance goes.
Could you help with a pull-request?
Yes
The text was updated successfully, but these errors were encountered: