Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running example #18

Open
DFJL opened this issue Jul 24, 2020 · 3 comments
Open

Running example #18

DFJL opened this issue Jul 24, 2020 · 3 comments

Comments

@DFJL
Copy link

DFJL commented Jul 24, 2020

Hi,
when I run the example code

datadrivencv::use_datadriven_cv(full_name = "Felipe Jiménez")

I got the following error:
Error: '/home/rstudio-user/R/x86_64-pc-linux-gnu-library/4.0/datadrivencv/templates/cv.rmd' does not exist.

Can you please adress this?

Thanks!

@mine-cetinkaya-rundel
Copy link

I just ran into this issue as well.

I believe this is because cv.rmd and render_cv.r are in .gitignore currently at https://github.com/nstrayer/datadrivencv/blob/master/.gitignore. I was able to triage this issue locally by removing these from the gitignore and also by making sure references to these files at https://github.com/nstrayer/datadrivencv/tree/master/inst/templates also use lower case R in the suffix (e.g. .rmd and .r).

@nstrayer I didn't do a PR for this fix because I'm not sure if this is the most principled way of solving this issue, or if I just happened upon a solution. But I would be happy to if you think that's the right way to fix it.

@nstrayer
Copy link
Owner

This issue is the same as nstrayer/datadrivencv#35. Basically I was foolish and tried to standardize on all the internal files being lowercase which broke backwards compatibility with parts of the package I cant guarantee would update.

Hopefully shortly I will get the issue fixed on the datadrivencv package and the issue should go away.

@mine-cetinkaya-rundel , The way I was planning on fixing is, instead of just looking for the file existance strictly, looking for it without respect to case, and then using that file. Something like

all_templates <- fs::file_ls(system.files("templates/", package = "datadrivencv"))$path
cv_loc <- all_templates[str_detect(all_templates, "render_cv.r")]

(Probably misremembered the syntax here).

If you have the bandwidth and desire to do it then I would welcome a PR! I have been a particularly poor open-source steward for this project due to releasing it right as I am trying to finish my PhD.

@mine-cetinkaya-rundel
Copy link

Thanks @nstrayer! I should have one more reason to use datadrivencv in the near future so I'll look into this then.

Focusing on the PhD sounds like the right thing, open-source will still be here when you're done! Thanks again for this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants