Skip to content

fix(testing): update yarn integration tests for remix and enable previously skipped tests #31933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

fix(testing): update yarn integration tests for remix and enable previously skipped tests #31933

merged 1 commit into from
Jul 17, 2025

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Jul 15, 2025 •
edited
Loading

These tests were skipped previously, we should re-enable them so that we have coverage.

@ndcunningham ndcunningham self-assigned this Jul 15, 2025
@nx-cloud Nx Cloud
Copy link
Contributor

nx-cloud bot commented Jul 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f7cf890

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 8m 20s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 3s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-15 20:53:20 UTC

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 15, 2025 8:42pm

@ndcunningham ndcunningham marked this pull request as ready for review July 16, 2025 15:27
@ndcunningham ndcunningham requested review from Coly010 and a team as code owners July 16, 2025 15:27
@ndcunningham ndcunningham enabled auto-merge (squash) July 16, 2025 16:26
@ndcunningham ndcunningham merged commit a42d7a3 into master Jul 17, 2025
5 checks passed
@ndcunningham ndcunningham deleted the fix/enable-remix-e2e-yarn-tests branch July 17, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongemi xiongemi xiongemi approved these changes

@Coly010 Coly010 Awaiting requested review from Coly010 Coly010 is a code owner

Assignees

@ndcunningham ndcunningham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndcunningham @xiongemi