Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked Install Strategy - part 2 | Testing & Migration #639

Open
5 of 10 tasks
raiyanalam opened this issue Jan 31, 2023 · 7 comments
Open
5 of 10 tasks

Linked Install Strategy - part 2 | Testing & Migration #639

raiyanalam opened this issue Jan 31, 2023 · 7 comments

Comments

@raiyanalam
Copy link

raiyanalam commented Jan 31, 2023

Summary

This epic is a continuation of Linked Install Strategy - part 1

Bugs

Exit Criteria

  • testing complete
    • MS Outlook hands on testing
    • new smoke tests with linked install strategy
    • cigtm with linked install strategy
  • any major bug fixes closed
  • msft team onboared and migrated to npm
  • Performance benchmark and numbers
  • npmjs Document changes
  • announcement blog post
@raiyanalam
Copy link
Author

@fritzy Please provide updates here
cc: @saquibkhan

@raiyanalam
Copy link
Author

raiyanalam commented Feb 23, 2023

RTB: @saquibkhan and team would evaluate the investment needed on this and scope accordingly.
@MylesBorins to help with alignment with MS team.

@saquibkhan
Copy link

@fritzy can you share the latest updates here

@satyaye
Copy link

satyaye commented Mar 7, 2023

@fritzy - a gentle nudge on this, please let us know whats the latest here

@fritzy
Copy link

fritzy commented Mar 14, 2023

I took last week off, and now diving into this week with an update.

Update 2023-03-14

  • Bugs preventing installs on certain repos have been fixed.
    • This doesn't mean that all repos will work. Some tools don't work with pnpm style installs, and some dependencies have incorrect dependencies of their own, working by coincidence in the default "hoisted" install mode.
    • Remaining bugs around performance and correctness when it comes to modifying existing installs are currently in progress.
  • The Outlook "client-web" repo, including CodeSpaces is working with the new install mode.
  • I'm working on finishing the Outlook report, including migration instructions, gaps, and benchmarks for Microsoft 1JS using the Outlook "client-web" repo as the primary example.

@saquibkhan
Copy link

@fritzy can you provide latest updates plz

@fritzy
Copy link

fritzy commented Mar 23, 2023

Update 2023-03-23 🟡

  • updating the standard benchmark suite to include workspaces and linked install strategy
  • improvements to loadactual to fix bugs with npm ls -a and subsequent installs reinstalling packages unnecessarily

Linked/Isolated Mode is nearly stable (2 bugs left), and our standard benchmarks will soon include this feature.
The hand-off for supporting 1JS at Microsoft will wrapup soon. That hand-off may go happen shortly after the new quarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants