Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Correct, warn, or both? #3

Open
myrne opened this issue Apr 8, 2013 · 1 comment
Open

[QUESTION] Correct, warn, or both? #3

myrne opened this issue Apr 8, 2013 · 1 comment
Labels

Comments

@myrne
Copy link
Contributor

myrne commented Apr 8, 2013

Some of original code gave warnings but did not fix. For example, the various typos that were defined.

Other parts corrects things silently. For example (from original).

function bugsTypoWarn (file, data) {
                var b = data.bugs
                if (!b || typeof b !== "object") return
                Object.keys(b).forEach(function (k) {
                                if (bugsTypos[k]) {
                                                b[bugsTypos[k]] = b[k]
                                                delete b[k]
                                }
                })
}

scriptTyposWarn on the other hand, warns but does not correct.

@myrne
Copy link
Contributor Author

myrne commented Apr 8, 2013

I think it would be good to have a guiding principle in this. What do we warn about, what do we fix silently, what do we fix and warn about?

@darcyclarke darcyclarke changed the title Correct, warn, or both? [QUESTION] Correct, warn, or both? Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants