RFC: use go modules #1451
Open
RFC: use go modules #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Happy to change over to Go modules. This needs a rebase. |
SantiagoTorres
force-pushed
the
use-go-modules
branch
from
36d1921 to
92f150f
Compare
|
@justincormack thanks for reviewing! Sorry for the delay, it's been rather busy lately... |
|
@SantiagoTorres could you update your PR to use Go 1.13 instead? That would also be aligned with another PR #1515 waiting to be merged. If you don't have time, I'm happy to file a replacement PR. |
|
Hi, I'll pick this up this weekend. Should be triival enough for me to update but let me take a look... |
Signed-off-by: Santiago Torres <[email protected]>
It appears that the newer version of gorethink(?) returns "No address associated with hostname" rather than a string containing "no host" as it was previously checked-for.
SantiagoTorres
force-pushed
the
use-go-modules
branch
from
92f150f to
8d16db7
Compare
|
@marcofranssen I updated this PR. I also had to fix one test(?), but I added it as a separate commit in case we want to discard that for now. |
|
This can probably be closed now that #1523 did this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just did this for the sake of avoiding GOPATH insanity and quality of life.
What do you people think?