Clarify maintainer rules #1390
Open
Clarify maintainer rules #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rove the PR for a new maintainer before merging. Update my email address in the maintainer list. Signed-off-by: cyli <[email protected]>
|
Can one of the admins verify this patch? |
|
Hi, |
|
I was the one who misunderstood the rules as it was written. It’s good to clarify how the process should work so this won’t happen again in the future. Thanks for pointing it out. |
endophage
approved these changes
Oct 17, 2018
justincormack
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @eiais pointed out and @endophage clarified in #1379, 2/3 supermajority of maintainers must approve a maintainer PR before it can be merged.
This PR updates the docs to specify, and while I'm at it update my email address.