Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rounded-corners): fix chrome border image repeat #438

Closed
wants to merge 2 commits into from
Closed

fix(rounded-corners): fix chrome border image repeat #438

wants to merge 2 commits into from

Conversation

stanleynguyen
Copy link

Description
Resolves #434

Compatibility

Backward-compatible

Caveats

@guastallaigor guastallaigor requested a review from a team September 30, 2020 16:12
@guastallaigor guastallaigor added bug Something isn't working waiting - reviewer Waiting for the reviewer to address some situations labels Sep 30, 2020
guastallaigor
guastallaigor reviewed Oct 2, 2020
View reviewed changes
Copy link
Member

@guastallaigor guastallaigor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. However, I tested using Storybook and Chrome Version 85.0.4183.121 (Official Build) (64-bit), and without this the borders is a lot worse in some resolutions / zooms.

With border-image-repeat: space

image

Without border-image-repeat: space

image

This means it's not perfect, but in my opinion it's better with border-image-repeat: space than without.
Could you share your environment, the tests that you've made and your opinion or some screenshots regarding this?
Thank you.

@guastallaigor guastallaigor added waiting - contributor Waiting for the contributor to address some situations and removed waiting - reviewer Waiting for the reviewer to address some situations labels Oct 2, 2020
@stanleynguyen
Copy link
Author

Thank you for your contribution. However, I tested using Storybook and Chrome Version 85.0.4183.121 (Official Build) (64-bit), and without this the borders is a lot worse in some resolutions / zooms.

With border-image-repeat: space

image

Without border-image-repeat: space

image

This means it's not perfect, but in my opinion it's better with border-image-repeat: space than without.
Could you share your environment, the tests that you've made and your opinion or some screenshots regarding this?
Thank you.

Thanks @guastallaigor for the feedback. I only checked on my Mac Air (13 & 11 inch) and didn't realise these issue above 🤔 Guess this is a more complicated problem than it seemed

@guastallaigor guastallaigor mentioned this pull request Dec 14, 2020
Open
@guastallaigor guastallaigor removed the waiting - contributor Waiting for the contributor to address some situations label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guastallaigor guastallaigor guastallaigor left review comments

Assignees

@stanleynguyen stanleynguyen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No longer needed in chrome and causes actual pixel to be spaced apart
2 participants
@stanleynguyen @guastallaigor