Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: split the InstallationService into three parts #7122

Closed
danzuep opened this issue Mar 23, 2024 · 1 comment
Closed

Refactor: split the InstallationService into three parts #7122

danzuep opened this issue Mar 23, 2024 · 1 comment

Comments

@danzuep
Copy link

danzuep commented Mar 23, 2024

nopCommerce version:

  • 4.70.8

Steps to reproduce the problem:

  • The InstallationService is massive, making local changes and synching is a pain (e.g. #7121).

Since the InstallationService is already a partial class, splitting it in three makes it easier to work with. An alternative (better?) way of doing this would be to inject two other services.

I've done this in my project here, but after I re-based I realised I'd missed some changes from @exileDev 21 hours ago, so maybe one of the core team should implement this.

@AndreiMaz
Copy link
Member

After some consideration we've decided not to implement this functionality out of the box and leave it for customization

@AndreiMaz AndreiMaz closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants