-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinafore is not just on localhost, but on all interfaces #2310
Comments
This would be a backwards-incompatible change. What is your use case for listening only on localhost? Would you be okay with an option to only listen on localhost? |
I would've expected it not to listen on all interfaces, especially since for the Docker instruction in the README, it says it listens on localhost. But yes, an option to only use localhost would be fine. |
@kescherCode can you give any more detail to what issue this causes you? |
Since Pinafore is, from what I can tell, typically not supposed to be exposed on all interfaces, but rather behind a reverse proxy, it would make that port needlessly accessible whenever it's not firewalled off. |
When starting the server for Pinafore using
PORT=4002 node server.js
, the server is in fact opened on all interfaces, not onlylocalhost:4002
.The text was updated successfully, but these errors were encountered: