Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop broken #501

Open
ronag opened this issue Nov 25, 2022 · 2 comments
Open

interop broken #501

ronag opened this issue Nov 25, 2022 · 2 comments

Comments

@ronag
Copy link
Member

ronag commented Nov 25, 2022

In utils we use:

const kDestroyed = Symbol('kDestroyed')
const kIsErrored = Symbol('kIsErrored')
const kIsReadable = Symbol('kIsReadable')
const kIsDisturbed = Symbol('kIsDisturbed')

But that means that using helper methods with node core stream will give incorrect results. I believe we need to also check the methods from 'stream'.

Alternatively change the core implementation to not use symbols...

@ronag
Copy link
Member Author

ronag commented Nov 25, 2022

See nodejs/undici@213cbfe

@mcollina
Copy link
Member

Is there any way to get those Symbols out from Node.js core? If not, we should make some change there first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants