chore: update lief (#23)

This change updates lief to
lief-project/LIEF@b183666.

This contains lief-project/LIEF#780, which is
a requirement for #8.

Signed-off-by: Darshan Sen <[email protected]>

Author: RaisinTen

DEPENDENCIES

@@ -1,2 +1,2 @@
-lief https://github.com/lief-project/LIEF/ 9cf3b56cf004407c56695a61688ecc8ac511ef0e
+lief https://github.com/lief-project/LIEF/ b183666a082d19ffc91ed0763f49e1d4f3814a59
 vendorpull https://github.com/jviotti/vendorpull 8445d0d0b15d308906ee395cc3313cba461865c4

vendor/lief/CMakeLists.txt

@@ -1,5 +1,10 @@
 cmake_minimum_required(VERSION 3.5)
 
+# Avoid warning about DOWNLOAD_EXTRACT_TIMESTAMP in CMake 3.24:
+if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.24.0")
+  cmake_policy(SET CMP0135 NEW)
+endif()
+
 set_property(GLOBAL PROPERTY USE_FOLDERS ON)
 
 # Modules
@@ -464,15 +469,6 @@ endif()
 
 target_compile_definitions(LIB_LIEF PUBLIC -D_GLIBCXX_USE_CXX11_ABI=1)
 
-# Enable support for MD2 and MD4 for parsing the Authenticode sigs of older
-# executables. Also, some older signed executables use certs with the
-# SpcSpAgencyInfo Critical Extension, which mbed TLS doesn't support, so set
-# MBEDTLS_X509_ALLOW_UNSUPPORTED_CRITICAL_EXTENSION to have it skip this
-# extension.
-add_definitions(-DMBEDTLS_FS_IO -DMBEDTLS_PEM_PARSE_C -DMBEDTLS_BIGNUM_C
-                -DMBEDTLS_X509_CRT_PARSE_C -DMBEDTLS_PEM_WRITE_C
-                -DMBEDTLS_PKCS1_V15 -DMBEDTLS_PKCS1_V21)
-
 # LIEF Sanitizer options
 # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 set(SANITIZER_FLAGS -fno-omit-frame-pointer -g -O1)

vendor/lief/api/c/MachO/Parser.cpp

@@ -25,19 +25,27 @@ using namespace LIEF::MachO;
 
 Macho_Binary_t** macho_parse(const char *file) {
   FatBinary* fat = Parser::parse(file).release();
+  if (fat == nullptr) {
+    return nullptr;
+  }
+
+  size_t nb_bin = fat->size();
 
   auto** c_macho_binaries = static_cast<Macho_Binary_t**>(
       malloc((fat->size() + 1) * sizeof(Macho_Binary_t**)));
 
-  for (size_t i = 0; i < fat->size(); ++i) {
+  for (size_t i = 0; i < nb_bin; ++i) {
     Binary* binary = fat->at(i);
     if (binary != nullptr) {
       c_macho_binaries[i] = static_cast<Macho_Binary_t*>(malloc(sizeof(Macho_Binary_t)));
       init_c_binary(c_macho_binaries[i], binary);
     }
   }
 
-  c_macho_binaries[fat->size()] = nullptr;
+  fat->release_all_binaries();
+
+  c_macho_binaries[nb_bin] = nullptr;
+  delete fat;
 
   return c_macho_binaries;
 }

vendor/lief/api/python/CMakeLists.txt

@@ -1,4 +1,10 @@
 cmake_minimum_required(VERSION 3.1)
+
+# Avoid warning about DOWNLOAD_EXTRACT_TIMESTAMP in CMake 3.24:
+if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.24.0")
+  cmake_policy(SET CMP0135 NEW)
+endif()
+
 include(ExternalProject)
 include(CheckCXXCompilerFlag)
 include(CheckCCompilerFlag)

vendor/lief/api/python/DEX/objects/pyType.cpp

@@ -73,7 +73,7 @@ void create<Type>(py::module& m) {
 
             case Type::TYPES::CLASS:
               {
-                return py::cast(type.cls());
+                return py::cast(type.cls(), py::return_value_policy::reference);
               }
 
             case Type::TYPES::PRIMITIVE:

vendor/lief/api/python/ELF/objects/pyBinary.cpp

@@ -500,7 +500,7 @@ void create<Binary>(py::module& m) {
         "permutation"_a)
 
     .def("write",
-        &Binary::write,
+        static_cast<void (Binary::*)(const std::string&)>(&Binary::write),
         "Rebuild the binary and write it in a file",
         "output"_a,
         py::return_value_policy::reference_internal)

vendor/lief/api/python/ELF/objects/pyBuilder.cpp

@@ -68,7 +68,7 @@ void create<Builder>(py::module& m) {
         py::return_value_policy::reference_internal)
 
     .def("write",
-        &Builder::write,
+        static_cast<void (Builder::*)(const std::string&) const>(&Builder::write),
         "Write the build result into the ``output`` file",
         "output"_a)
 

vendor/lief/api/python/MachO/objects/pyBinary.cpp

@@ -424,7 +424,7 @@ void create<Binary>(py::module& m) {
         "address"_a)
 
     .def("write",
-        &Binary::write,
+        static_cast<void (Binary::*)(const std::string&)>(&Binary::write),
         "Rebuild the binary and write and write its content if the file given in parameter",
         "output"_a,
         py::return_value_policy::reference_internal)
@@ -584,7 +584,9 @@ void create<Binary>(py::module& m) {
         py::return_value_policy::reference_internal)
 
     .def("shift",
-         &Binary::shift,
+         [] (Binary& self, size_t width) {
+           return error_or(&Binary::shift, self, width);
+         },
          R"delim(
          Shift the content located right after the Load commands table.
          This operation can be used to add a new command

vendor/lief/api/python/PE/objects/pyBinary.cpp

@@ -405,7 +405,7 @@ void create<Binary>(py::module& m) {
         "Remove all imported libraries")
 
     .def("write",
-        &Binary::write,
+        static_cast<void (Binary::*)(const std::string&)>(&Binary::write),
         "Build the binary and write the result to the given ``output`` file",
         "output_path"_a)
 

vendor/lief/api/python/PE/objects/pyBuilder.cpp

@@ -94,7 +94,7 @@ void create<Builder>(py::module& m) {
         py::return_value_policy::reference)
 
     .def("write",
-        &Builder::write,
+        static_cast<void (Builder::*)(const std::string&) const>(&Builder::write),
         "Write the build result into the ``output`` file",
         "output"_a)