[LoongArch] Compilation Error in Main Branch Due to Brotli Dependency: "invalid argument of ‘model’ attribute"

[Javonne-liu]

Version

v26.0.0-pre

Platform

Linux 90 6.9.0-rc3_default #1 SMP PREEMPT Thu Apr 11 12:24:48 UTC 2024 loongarch64 GNU/Linux

Subsystem

deps/brotli

What steps will reproduce the bug?

./configure --openssl-no-asm && make -j32

How often does it reproduce? Is there a required condition?

Architecture: LoongArch64
Node.js version: Main branch (latest commit)

What is the expected behavior? Why is that the expected behavior?

Expected behavior: Node.js should compile successfully on the LoongArch64 architecture without compilation errors related to the brotli dependency

What do you see instead?

Instead of a successful compilation, we encounter error during the brotli dependency build phase.

Additional information

In the LoongArch architecture, the upstream Node.js CI (https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/835/) is encountering a compilation error related to brotli, with the specific error message being "invalid argument of ‘model’ attribute".
During reproduction testing, we found that updating the brotli submodule to commit (e230f474) can effectively prevent Node.js build failures on the LoongArch architecture.
The root cause of this problem is that the GCC compiler does not support the ((model("small"))) attribute.
For reference, please see: google/brotli#1369 and google/brotli/pull/1368.

[Javonne-liu]

I would like to inquire: can the fix patch be cherry-picked into deps/brotli, or will we have to wait for the next version upgrade? If cherry-picking is not feasible, could you please estimate how long it will take for the next upgrade (which includes this fix)?
This is extremely important to me, and I’d be truly grateful for your response!

[marco-ippolito]

the issue was introduced in 1.2.0? #60540
We usually have to wait for a new brotli release

[Javonne-liu]

the issue was introduced in 1.2.0? #60540这个问题是在 1.2.0 版本中引入的吗？ #60540 We usually have to wait for a new brotli release我们通常需要等待新的 brotli 发布。

Yes, this issue was indeed introduced in brotli 1.2.0 and started occurring after the merge of #60540. From what I’ve observed, a fix for this problem was already implemented in brotli’s codebase following the 1.2.0 release.
Given that official brotli releases typically take a considerable amount of time to roll out, I’m wondering if it would be feasible to cherry-pick this fix directly into the deps/brotli branch of Node.js?
Thank you so much for taking the time to look into this matter—I really appreciate your help! @marco-ippolito