-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport undici MessageEvent to v20. #53009
Comments
cc @KhafraDev |
The errors were spec compliant, it's semver-major because it changed the error messages themselves. Since undici implements the webidl spec, and reuses it between everything web-related it implements, it's not feasible to match the errors to the old node ones (which were inconsistent). I'd recommend backporting #52763 as well for better error messages and #52951 (when it lands) to make it fast. |
In today's TSC meeting, we agreed to backport it to v22, but not v20 and v18. We'll see if it's problematic via CITGM (we don't expect it to be). |
#52370 is tagged as semver-major because it changes an error message to be spec-compliant.
I recommend we backport it to Node v22 to ease long-term maintenance.
The text was updated successfully, but these errors were encountered: