Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable test-ubsan.yml #52753

Open
RafaelGSS opened this issue Apr 29, 2024 · 1 comment
Open

Re-enable test-ubsan.yml #52753

RafaelGSS opened this issue Apr 29, 2024 · 1 comment
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. meta Issues and PRs related to the general management of the project.

Comments

@RafaelGSS
Copy link
Member

During the latest Node.js major release (#52505) we have had to disable test-ubsan.yml due to failing tests on a recent V8 update (#52560).

I have tried to make it work, but due to the short time frame I had to fix it, we have decided to simply disable it for now.

Some insights:

  • It seems clang provides a better output and some docs we could use in the suppressions file.
    • Changing from g++ to clang for UBSAN will require changing all the suppression file
@RafaelGSS RafaelGSS added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Apr 29, 2024
@RedYetiDev RedYetiDev added the meta Issues and PRs related to the general management of the project. label Apr 29, 2024
@richardlau
Copy link
Member

For reference, the ubsan failure in #52293 (comment) is abseil/abseil-cpp#1634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richardlau @RafaelGSS @RedYetiDev