Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic detection of "Fixes" should be stricter #592

Open
tniessen opened this issue Nov 11, 2021 · 1 comment
Open

Automatic detection of "Fixes" should be stricter #592

tniessen opened this issue Nov 11, 2021 · 1 comment
Labels

Comments

@tniessen
Copy link
Member

In nodejs/node#40613, [email protected] incorrectly adds a Fixes: metadata line:

----------------------------------- PR info ------------------------------------
Title      crypto: fix build without scrypt (#40613)
Author     Martin 'JaMa' Jansa <[email protected]> (@shr-project, first-time contributor)
Branch     shr-project:jansa/scrypt -> nodejs:master
Labels     crypto, c++, author ready
Commits    1
 - crypto: fix build without scrypt
Committers 1
 - Martin Jansa <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/40613
Fixes: https://github.com/In
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40613
Fixes: https://github.com/In
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
--------------------------------------------------------------------------------

The commit message was:

crypto: fix build without scrypt

* add missing semicolon to fix:
  In file included from ../src/node_crypto.h:47,
                   from ../src/node.cc:46:
  ../src/crypto/crypto_scrypt.h:80:2:
  error: expected ';' after struct definition
     80 | }
        |  ^
        |  ;

  and fix typo in the comment

Signed-off-by: Martin Jansa <[email protected]>

(Original post in nodejs/node#40613 (comment).)

@tniessen tniessen added the bug label Nov 11, 2021
@richardlau
Copy link
Member

I think it's being picked out of the body of the pull request description. The same issues is also often seen with the npm update pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants