Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script doesn't work on arm64 macs #1848

Closed
SimenB opened this issue Feb 17, 2023 · 0 comments · Fixed by #2073
Closed

Update script doesn't work on arm64 macs #1848

SimenB opened this issue Feb 17, 2023 · 0 comments · Fixed by #2073

Comments

@SimenB
Copy link
Member

SimenB commented Feb 17, 2023

Running ./update.sh results in functions.sh: line 42: arch: unbound variable. uname -m returns arm64 which is not present in the case, so that makes sense (we really should fix the logging, but whatever).

Adding arm64 to the list (mapping to arm64) generates a diff adding that arch to the Dockerfiles (e.g. FROM arm64/debian:buster-slim), which I don't think is what we want?

We really should land #1368

/cc @nodejs/docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@SimenB and others