Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag protection rules #1190

Open
richardlau opened this issue Mar 16, 2022 · 9 comments
Open

Tag protection rules #1190

richardlau opened this issue Mar 16, 2022 · 9 comments

Comments

@richardlau
Copy link
Member

richardlau commented Mar 16, 2022

In beta.
Refs: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-tag-protection-rules

It's might be a good idea to turn this on. We'd need to make sure @nodejs/releasers would be still be able to create the tags for releases.

@targos
Copy link
Member

targos commented Mar 16, 2022

I tried to enable it, but quickly reverted the change, because:

Only users with admin or maintain permissions in the repository will be able to create protected tags, and only users with admin permissions in the repository will be able to delete protected tags.

@richardlau
Copy link
Member Author

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-tag-protection-rules claims:

Additionally, you can create custom repository roles to allow other groups of users to create or delete tags that match tag protection rules. For more information, see "Managing custom repository roles for an organization."

@targos
Copy link
Member

targos commented Mar 16, 2022

Unfortunately, I don't think we have access to custom repository roles. At least I can't find the option in the org settings.

@targos targos closed this as completed Mar 16, 2022
@targos targos reopened this Mar 16, 2022
@targos
Copy link
Member

targos commented Mar 16, 2022

It seems to be a feature specific to "Enterprise Cloud" GitHub.

@MylesBorins
Copy link
Member

I can bring feedback to the team that worked on this

@ljharb
Copy link
Member

ljharb commented Mar 18, 2022

There also doesn't seem to be a way to block creation of tags that don't match a pattern, but i guess that's consistent with branch protections.

@MylesBorins
Copy link
Member

'*' ;)

@JasonEtco
Copy link

Hey folks 👋 I worked on this feature, and @MylesBorins was kind enough to share this issue with me. Just wanted to let y'all know that we're looking into applying the same treatment that branch protection has, of specifying a team/user to be able to bypass a tag protection rule.

For context, our initial reasoning for not doing that was to instead rely on custom roles - but we've heard the feedback that OSS projects don't have that capability (as its an Enterprise Cloud feature [I do not know why and it bugs me]), so there's a gap here. I'll drop a note in here if/when that's available. Thanks for sharing your feedback 🙏

@richardlau
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants