Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI tools behind a Nodejs namespace #1178

Open
danielleadams opened this issue Feb 25, 2022 · 19 comments
Open

CLI tools behind a Nodejs namespace #1178

danielleadams opened this issue Feb 25, 2022 · 19 comments

Comments

@danielleadams
Copy link
Member

Not sure if this is the right place for this issue, so I am happy to move it. I opened it here because it affects multiple tools in the Node.js org.

Since the installation instructions on the Node.js tooling (ie. https://github.com/nodejs/node-core-utils, https://github.com/nodejs/changelog-maker, etc) recommend a global install, should these be put under a Node.js scope on the npm registry such as @nodejs/<packagename>?

It establishes a level of trust in the published packages ("I know this came from the Node org"), and it will hopefully help contributors avoid accidental installations of similarly named packages.

Docs: https://docs.npmjs.com/cli/v8/using-npm/scope

@ljharb
Copy link
Member

ljharb commented Feb 25, 2022

Perhaps they should also recommend using npx instead, since global installs are widely discouraged in the community.

@danielleadams
Copy link
Member Author

@ljharb yeah, we should probably do both

@mmarchini
Copy link
Contributor

I like the idea of using namespace but would rather not use @nodejs, as that might encourage project specific tools to be used externally, which is not recommended. Something like @nodejs-dev maybe?

@mhdawson
Copy link
Member

Or maybe even something more specific like @nodejs-dev-internal ?

@mcollina
Copy link
Member

mcollina commented Mar 2, 2022

I'm ok to use an org/scope but not @nodejs. I'm ok with @nodejs-dev but I think @nodejs-core is more explicit in intent.

@targos
Copy link
Member

targos commented Mar 2, 2022

I like @nodejs-core or @node-core.

node-core-utils could be renamed to @node-core/utils

@mcollina
Copy link
Member

mcollina commented Mar 2, 2022

@node-core/utils has a nice sound.

@MylesBorins
Copy link
Member

+1 for @node-core

it looks like the scope is currently being squatted but if someone opens a ticket with npm support (shouldn't be me) I can look into getting us access

@mhdawson
Copy link
Member

mhdawson commented Apr 5, 2023

@danielleadams
Copy link
Member Author

I think that was me that squatted on it shortly after we discussed initially. Never got around to moving this forward, but I can unsquat so we can use it.

@Ethan-Arrowood
Copy link
Contributor

Relative to the thread I just opened on admin (nodejs/admin#794) I like the idea of dev-related stuff being published under a different scope than public stuff.

@Ethan-Arrowood
Copy link
Contributor

Making a plan to solve this with @danielleadams .

@mhdawson
Copy link
Member

I just received notification that node-core was transferred to the nodejs-foundation account. We can now start publishing packages in that namespace.

@Ethan-Arrowood
Copy link
Contributor

Do we have @nodejs too? I don't think its been decided yet what the external scope will be, but i think that one was shared during collab summit

@mhdawson
Copy link
Member

Right now we have node, node-core and pkgjs

@mhdawson
Copy link
Member

@danielleadams now that we have node-core what are the next steps and does this still need to be on the TSC agenda.

@Ethan-Arrowood
Copy link
Contributor

@mhdawson I think we need to merge nodejs/admin#795 too + make the public facing scope happen

@mhdawson
Copy link
Member

mhdawson commented Jun 7, 2023

Discussed in meeting today. Those in attenance agreed should be ok to start migrating packages to the node-core namespace as we have the namespace and no objections have been raised.

@Ethan-Arrowood
Copy link
Contributor

Ethan-Arrowood commented Sep 13, 2023

I'm glad to see @node-core was approved. Can y'all discuss another scope for public facing modules next? Thank you! RE: nodejs/admin#794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants