Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vote lifecycle workflows and scripts #1401

Merged
merged 9 commits into from Mar 16, 2024
Merged

Add vote lifecycle workflows and scripts #1401

merged 9 commits into from Mar 16, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 14, 2023

This PR adds automation and documentation for vote initialisations, it adds automation to report invalid vote commits, and to close votes.

Code reviews are welcome, note that we should wait for the transfer of Caritat npm package to the @node-core scope to be completed before landing.

Blocked on: nodejs/node-core-utils#704
Fixes: #1165

@github-actions github-actions bot changed the base branch from main to initiateNewVote June 14, 2023 11:19
@aduh95 aduh95 mentioned this pull request Jun 14, 2023
Open
@mhdawson
Copy link
Member

I won't have time to review in detail but trust that @aduh95 with in good shape and think having it captured/documeted in the repo is better than no. Will add my Rubber Stamp LGTM

mhdawson
mhdawson approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

mcollina
mcollina approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aduh95
aduh95 commented Jun 28, 2023
View reviewed changes
.github/workflows/closeVote.yml Outdated Show resolved Hide resolved
.github/workflows/initiateNewVote.yml Outdated Show resolved Hide resolved
.github/workflows/watchVote.yml Outdated Show resolved Hide resolved
votes/initiateNewVote/decryptPrivateKeyAndCloseVote.mjs Outdated Show resolved Hide resolved
votes/initiateNewVote/generateNewVotePR.mjs Outdated Show resolved Hide resolved
votes/initiateNewVote/getVoteStatus.mjs Outdated Show resolved Hide resolved
@mhdawson
Copy link
Member

@aduh95 is this ready to land?

@aduh95 aduh95 merged commit 5bdd3a9 into initiateNewVote Mar 16, 2024
4 checks passed
@aduh95 aduh95 deleted the vote-automations branch March 16, 2024 10:36
@aduh95 aduh95 mentioned this pull request Mar 27, 2024
Merged
aduh95 added a commit that referenced this pull request Apr 10, 2024
@aduh95
Add vote lifecycle workflows and scripts (#1401) (#1522)
2bfba10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[meta] settle on a voting solution
4 participants
@aduh95 @mhdawson @mcollina @gireeshpunathil