Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to convert header keys to lower case due to field name conflict: content-type #2235

Open
maxwhoppa opened this issue Oct 21, 2021 · 3 comments · Fixed by MuckT/nock#1
Labels
awaiting response support General questions or support.

Comments

@maxwhoppa
Copy link

What is the expected behavior?

nock does not cause an error if headers have uppercase letters

What is the actual behavior?

Content-Type in header request causes a conflict

Possible solution

Not failing on lowercase conflict

How to reproduce the issue

Make a request with Content-Type in header request

  'Content-Type': 'application/json',

Versions

Software Version(s)
Nock 13.1.3
Node 14.7.6
TypeScript 4.3.2

related issue: #1191

@gr2m
Copy link
Member

gr2m commented Oct 21, 2021

Can you replicate the problem using a test case on https://runkit.com/? Example: https://runkit.com/gr2m/nock-nock-1076

@DomGarguilo
Copy link

Is this related to #23?

@gr2m
Copy link
Member

gr2m commented Nov 8, 2021

Is this related to #23?

maybe? It's 9 years old though. Having a reproducible test case would still be a big help, either on RunKit.com or using a pull request with a failing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response support General questions or support.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants