Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actor in webshop does not intake the memory and relfexion #36

Open
yananchen1989 opened this issue Feb 1, 2024 · 7 comments
Open

actor in webshop does not intake the memory and relfexion #36

yananchen1989 opened this issue Feb 1, 2024 · 7 comments

Comments

@yananchen1989
Copy link

hi there,

I am a bit confused about the reflexion for webshop.
in code here, line 245,
https://github.com/noahshinn/reflexion/blob/main/webshop_runs/webshop_trial.py
the llm actor only intakes the base_prompt + prompt, which is the trajectory in current step, which is the left yellow block in the figure.
image

however, it seems that the llm actor does not intake the env_history which is the right yellow block in the figure, which contains the memory and reflexion from previous trials (if trial > 1)

may I know if I miss something ?

if this llm actor surely does not intake the memory, can it be explained that there is no gain in webshop task, as you reported in the paper ?
thanks.

@yananchen1989
Copy link
Author

i forked your repo and made changes here main...yananchen1989:reflexion:yc#diff-36a02556b49e22008fa36a519bf0cde61f8343559dfde60a3c229fb72176d00fR304

not sure it should be like that. please advise.

@yananchen1989
Copy link
Author

yananchen1989 commented Feb 5, 2024

image
my tested results.
fyi

@theblackcat102
Copy link

@yananchen1989 can I ask which columns belongs to your changes? with reflex?

@yananchen1989
Copy link
Author

yananchen1989 commented Apr 13, 2024

@yananchen1989 can I ask which columns belongs to your changes? with reflex?

hello.
line 304
@theblackcat102
action = llm_chat(str(env_history) + "\n\nAction:", stop=['\n']).strip().lstrip(' ') # fix the reflexion

@yananchen1989
Copy link
Author

i guess this could be a bug in the original code which causes the wrong conclusion with regards to webshop.
correct me if I miss something

@DZ9
Copy link

DZ9 commented Sep 4, 2024

image my tested results. fyi

@yananchen1989 Hi, may I know which model does this result come from?

@noahshinn
Copy link
Owner

image my tested results. fyi

Wow! I missed this result, but thank you for finding this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants