Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back section tagging #157

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Adding back section tagging #157

merged 2 commits into from
Jan 29, 2025

Conversation

sbreitbart-NOAA
Copy link
Collaborator

What is the feature?

  • Adding section tagging

How have you implemented the solution?

  • Adding missing section tags

Does the PR impact any other area of the project, maybe another repo?

  • No

Copy link
Contributor

Instructions for code reviewer

Hello reviewer, thanks for taking the time to review this PR!

  • Please use this checklist during your review, checking off items that you have verified are complete!
  • For PRs that don't make changes to code (e.g., changes to README.md or Github actions workflows), feel free to skip over items on the checklist that are not relevant. Remember it is still important to do a thorough review.
  • Then, comment on the pull request with your review indicating where you have questions or changes need to be made before merging.
  • Remember to review every line of code you’ve been asked to review, look at the context, make sure you’re improving code health, and compliment developers on good things that they do.
  • PR reviews are a great way to learn, so feel free to share your tips and tricks. However, for optional changes (i.e., not required for merging), please include nit: (for nitpicking) before making the suggestion. For example, nit: I prefer using a data.frame() instead of a matrix because...
  • Engage with the developer when they respond to comments and check off additional boxes as they become complete so the PR can be merged in when all the tasks are fulfilled. Make it clear when this has been reached by commenting on the PR with something like This PR is now ready to be merged, no changes needed.

Checklist

  • The PR is requested to be merged into the appropriate branch (typically main)
  • The code is well-designed.
  • The functionality is good for the users of the code.
  • Any User Interface changes are sensible and look good.
  • The code isn’t more complex than it needs to be.
  • Code coverage remains high, indicating the new code is tested.
  • The developer used clear names for everything.
  • Comments are clear and useful, and mostly explain why instead of what.
  • Code is appropriately documented (doxygen and roxygen).

@sbreitbart-NOAA sbreitbart-NOAA self-assigned this Jan 27, 2025
@sbreitbart-NOAA sbreitbart-NOAA marked this pull request as ready for review January 27, 2025 17:10
@sbreitbart-NOAA sbreitbart-NOAA added this to the 2025 Q2 Goals milestone Jan 27, 2025
@sbreitbart-NOAA sbreitbart-NOAA linked an issue Jan 27, 2025 that may be closed by this pull request
Schiano-NOAA
Schiano-NOAA previously approved these changes Jan 28, 2025
Copy link
Collaborator

@Schiano-NOAA Schiano-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made a small note about the directory for the test examples, otherwise good to merge

@sbreitbart-NOAA sbreitbart-NOAA merged commit 3b78dee into main Jan 29, 2025
6 checks passed
@sbreitbart-NOAA sbreitbart-NOAA deleted the sec-headers branch January 29, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add section tagging (i.e. {#sec-intro})
2 participants