Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't break lines after opening quote or before ellipsis or closing quote #5

Open
josteinaj opened this issue Jun 27, 2017 · 7 comments

Comments

@josteinaj
Copy link
Member

From @bertfrees on March 2, 2016 13:11

For example, like this:

Lisa gikk langt til
sk…

«Lisa gikk til til gikk
til …»

Dette tror faktisk jeg 
også …

«Nå er det nok forfo i dag,»
sa hun.

and not like this:

Lisa gikk langt til sk
…

«Lisa gikk til til gikk til
…»

Dette tror faktisk jeg også
…

«Nå er det nok forfo i dag,
» sa hun.

Copied from original issue: nlbdev/pipeline-mod-nlb#23

@josteinaj
Copy link
Member Author

From @bertfrees on March 2, 2016 13:23

In the cases where there is no space between the letter and the ellipsis or quote it is probably working fine already. In the cases with a space (2nd and 3rd examples) it is probably not working. A possible fix is to replace those spaces with no-break spaces.

@KariRudjord is first going to test some more.

@KariRudjord
Copy link

Right, @josteinaj and @bertfrees it is not working when there is a space before the ellipse. A no-break space would be nice!

A quote shall always stand together with the word, and it works fine!!

@josteinaj
Copy link
Member Author

Ok, thanks. We'll fix this during pre-processing later.

@josteinaj
Copy link
Member Author

Added related issue to NLBPUB project here: nlbdev/nlbpub#6

@josteinaj josteinaj self-assigned this May 25, 2018
@KariRudjord
Copy link

We need to put in a unicode hard space between the word and the ellipse (...) so that we avoid behaviour as this:
image
image

@KariRudjord
Copy link

KariRudjord commented Oct 12, 2018

A preprosessing thing, not a part of the translation. Easy to fix. Bert will look into it.

bertfrees added a commit that referenced this issue Nov 9, 2018
@josteinaj josteinaj removed their assignment Nov 22, 2018
@bertfrees
Copy link
Collaborator

Forgot to move this to "Ready for test". It was fixed in commit 0e91d95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants