Skip to content

Commit 1e65a79

Browse files
committed
ui fixes
1 parent bed5640 commit 1e65a79

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

src/assets/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@
133133
:class="{'d-none': filterSelected
134134
&& !(current.folder.id == folder.id || current.feed.folder_id == folder.id)
135135
&& !filteredFolderStats[folder.id]
136-
&& (!itemSelectedDetails || feedsById[itemSelectedDetails.feed_id].folder_id != folder.id)}">
136+
&& (!itemSelectedDetails || (feedsById[itemSelectedDetails.feed_id] || {}).folder_id != folder.id)}">
137137
<input type="radio" name="feed" :value="'folder:'+folder.id" v-model="feedSelected" v-if="folder.id">
138138
<div class="selectgroup-label d-flex align-items-center w-100" v-if="folder.id">
139139
<span class="icon mr-2"
@@ -274,7 +274,7 @@
274274
<span class="icon icon-small mr-1" v-if="item.status=='starred'">{% inline "star-full.svg" %}</span>
275275
</transition>
276276
<small class="flex-fill text-truncate mr-1">
277-
{{ feedsById[item.feed_id].title }}
277+
{{ (feedsById[item.feed_id] || {}).title }}
278278
</small>
279279
<small class="flex-shrink-0"><relative-time v-bind:title="formatDate(item.date)" :val="item.date"/></small>
280280
</div>
@@ -338,7 +338,7 @@
338338
<div class="content-wrapper">
339339
<h1><b>{{ itemSelectedDetails.title || 'untitled' }}</b></h1>
340340
<div class="text-muted">
341-
<div>{{ feedsById[itemSelectedDetails.feed_id].title }}</div>
341+
<div>{{ (feedsById[itemSelectedDetails.feed_id] || {}).title }}</div>
342342
<time>{{ formatDate(itemSelectedDetails.date) }}</time>
343343
</div>
344344
<hr>

src/assets/javascripts/app.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,7 @@ var vm = new Vue({
410410
refreshItems: function(loadMore) {
411411
if (this.feedSelected === null) {
412412
vm.items = []
413+
vm.itemsHasMore = false
413414
return
414415
}
415416

@@ -516,10 +517,7 @@ var vm = new Vue({
516517
deleteFolder: function(folder) {
517518
if (confirm('Are you sure you want to delete ' + folder.title + '?')) {
518519
api.folders.delete(folder.id).then(function() {
519-
if (vm.feedSelected === 'folder:'+folder.id) {
520-
vm.items = []
521-
vm.feedSelected = ''
522-
}
520+
vm.feedSelected = null
523521
vm.refreshStats()
524522
vm.refreshFeeds()
525523
})
@@ -536,12 +534,7 @@ var vm = new Vue({
536534
deleteFeed: function(feed) {
537535
if (confirm('Are you sure you want to delete ' + feed.title + '?')) {
538536
api.feeds.delete(feed.id).then(function() {
539-
// unselect feed to prevent reading properties of null in template
540-
var isSelected = !vm.feedSelected
541-
|| (vm.feedSelected === 'feed:'+feed.id
542-
|| (feed.folder_id && vm.feedSelected === 'folder:'+feed.folder_id));
543-
if (isSelected) vm.feedSelected = null
544-
537+
vm.feedSelected = null
545538
vm.refreshStats()
546539
vm.refreshFeeds()
547540
})

0 commit comments

Comments
 (0)