Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue: Codebase Improvements #380

Open
2 of 5 tasks
HeitorAugustoLN opened this issue Oct 10, 2024 · 4 comments
Open
2 of 5 tasks

Tracking Issue: Codebase Improvements #380

HeitorAugustoLN opened this issue Oct 10, 2024 · 4 comments

Comments

@HeitorAugustoLN
Copy link
Member

HeitorAugustoLN commented Oct 10, 2024

Feedback and suggestions on these proposed changes are welcome :)

General

Codebase

  • Remove with lib; at the Beginning of Files: Avoid using with lib; at the start of files to improve code clarity, especially in environments lacking tree-sitter or a robust LSP. Removing these statements will make scoping clearer and align with the best practices outlined in Nix documentation.

New features

  • Implement plasma-manager CLI Interface: Develop a unified CLI tool named plasma-manager to unify our scripts like rc2nix and write-config, as mentioned in Make rc2nix stable #337. This tool will serve as a single entry point for current and future scripts (e.g., kxmlgui), promoting a shared library for our scripts. The CLI will be installed by default when enabling plasma-manager, allowing users to execute commands like plasma-manager rc2nix.
@magnouvean
Copy link
Collaborator

These all look like very good suggestions to me. The stable release branch is the only one I'm a little unsure about since it would take quite a lot of work, but I can see the issue we have without support for this as well, so I'd be OK with it :)

@HeitorAugustoLN
Copy link
Member Author

These all look like very good suggestions to me. The stable release branch is the only one I'm a little unsure about since it would take quite a lot of work, but I can see the issue we have without support for this as well, so I'd be OK with it :)

Thanks for the feedback! I get your hesitation about the stable release branch, it does sound like a lot of work. But I don’t think it'll be too crazy. The biggest part is just checking if changes are backward-compatible, and after that, we can just use the backport workflow I set up in #383 to handle the rest. Shouldn’t be too bad! 😄

SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
@SigmaSquadron
Copy link
Contributor

Adopt Conventional Commits: Transition to using conventional commit messages in the format: [optional component]: .

If I may provide my two cents here: I really dislike the standard "conventional commit" messages which include the type. Often, commits won't necessarily conform to a specific category, and repos using conventional commits often end up just having chores and feats everywhere, even for things like refactors or releases, which does nothing but clutter the git history.

Since this is a Nix project, why not adapt the Nixpkgs commit conventions?

@HeitorAugustoLN
Copy link
Member Author

If I may provide my two cents here: I really dislike the standard "conventional commit" messages which include the type. Often, commits won't necessarily conform to a specific category, and repos using conventional commits often end up just having chores and feats everywhere, even for things like refactors or releases, which does nothing but clutter the git history.

Since this is a Nix project, why not adapt the Nixpkgs commit conventions?

Nixpkgs commit convention would also be good. But it wouldn't really help that much with versioning, and I really like the type in conventional commits. And it wouldn't be generally a problem here, because most of the commits are new features or fixes. But nixpkgs commit convention would not be a bad idea also.

SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron added a commit to SigmaSquadron/plasma-manager that referenced this issue Oct 19, 2024
Fixes (partially) nix-community#380

Signed-off-by: Fernando Rodrigues <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants