Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer as an LSP in kate stopped working #197

Open
Asqiir opened this issue Jun 9, 2024 · 5 comments
Open

rust-analyzer as an LSP in kate stopped working #197

Asqiir opened this issue Jun 9, 2024 · 5 comments

Comments

@Asqiir
Copy link
Contributor

Asqiir commented Jun 9, 2024

This regression was introduced in #191 which updated kate from 23.08 to 24.05. I believe it was this specific commit from the kate project.

I could fix this locally with adding the old version of rust-analyzer as a custom setting.

  1. Can somebody on a different setup check whether they can reproduce this?
  2. If so, can we figure out (with reasonable effort), what the root cause is?
  3. If not, should we add my hacky patch to plasma-manager's kate?
@Asqiir
Copy link
Contributor Author

Asqiir commented Jun 9, 2024

@ugur-a
Copy link
Contributor

ugur-a commented Jul 7, 2024

hi, it seems like you forgot to close this issue

@Asqiir
Copy link
Contributor Author

Asqiir commented Jul 7, 2024

@ugur-a I was hoping for somebody else to confirm (or reject) whether they have the same issue: If it's just me, we can close it. If it's a common issue, I would like to know to figure out a good fix.

@ugur-a
Copy link
Contributor

ugur-a commented Jul 10, 2024

Oh god sorry I totally misread this. So:

  1. I created a small config (literally just the rust-analyzer setup), and it does indeed fail to find the workspace when I don't have "rootIndicationFileNames" = ["Cargo.lock" "Cargo.toml"]; set.
  2. Unfortunately, I have no idea what the root cause could be. But the Reddit post's OP didn't say anything about plasma-manager (or home-manager in general), so nothing would indicate that it's the one to blame?
  3. Whatever that would be, I'd say your workaround couldn't hurt?

@Asqiir
Copy link
Contributor Author

Asqiir commented Jul 17, 2024

The root cause is that they removed these rootIndicatorFilenames from upstream kate. And if this is a common issue, somebody (I) should probably file a bug report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants